Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Memoize email to user lookup from Slack #4637

Merged
merged 2 commits into from
Mar 6, 2025
Merged

🐛 Memoize email to user lookup from Slack #4637

merged 2 commits into from
Mar 6, 2025

Conversation

Marigold
Copy link
Contributor

@Marigold Marigold commented Mar 6, 2025 •
edited
Loading

Memoize getSlackMentionByEmail to avoid rate limiting. If this keeps happening, we can also fetch email -> slack mapping from users table.

@Marigold Marigold requested a review from rakyi March 6, 2025 12:42
rakyi
rakyi approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the duplicate import.

@owidbot
Copy link
Contributor

owidbot commented Mar 6, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-cache-slack-emails

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-03-06 12:57:45 UTC
Execution time: 1.21 seconds

@Marigold Marigold merged commit 9459442 into master Mar 6, 2025
27 checks passed
@Marigold Marigold deleted the cache-slack-emails branch March 6, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakyi rakyi rakyi approved these changes

Assignees

@Marigold Marigold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marigold @owidbot @rakyi